Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POL-1298 - New Template: Flexera Onboarding v0.1.0 #2450

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

POL-1298 - New Template: Flexera Onboarding v0.1.0 #2450

wants to merge 28 commits into from

Conversation

bryankaraffa
Copy link
Contributor

Description

This policy checks various configurations in your Organization to ensure that it is set up correctly. The checks and recommendations are opinionated, and align with recommended best practices for onboarding and productionizing your Organization.

Issues Resolved

https://flexera.atlassian.net/browse/POL-1298

Link to Example Applied Policy

https://app.flexera.com/orgs/6/automation/applied-policies/projects/7954?policyId=669acdc8a09cd9483203663e

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

@bryankaraffa bryankaraffa added the enhancement New feature or request label Jul 22, 2024
@bryankaraffa bryankaraffa requested a review from a team as a code owner July 22, 2024 18:28
@bryankaraffa bryankaraffa changed the title New Template: Flexera Onboarding v0.1.0 POL-1298 - New Template: Flexera Onboarding v0.1.0 Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

1 Error
🚫

operational/flexera/onboarding/flexera_onboarding.pt

Flexera policy is not contained in a subdirectory specific to the Flexera service it is for. For example, Flexera CCO cost policies should be in the /cost/flexera/cco subdirectory.
2 Warnings
⚠️

Important Files Modified

Please make sure these modifications were intentional and have been tested. These files are necessary for configuring the Github repository and managing automation.

.dangerfile/policy_tests.rb
.spellignore
⚠️

operational/flexera/onboarding/flexera_onboarding.pt

Detected new request datasource(s) in Policy Template file. Please verify the README.md has any new permissions that may be required.

Generated by 🚫 Danger

@nia-vf1 nia-vf1 self-assigned this Aug 8, 2024
@bryankaraffa bryankaraffa requested a review from a team August 9, 2024 16:08
@bryankaraffa bryankaraffa force-pushed the feat/POL-1298_new_pt_flexera_onboarding branch from 1390ba7 to 8ac8846 Compare August 15, 2024 18:32
@nia-vf1 nia-vf1 assigned bryankaraffa and unassigned nia-vf1 Aug 30, 2024
bryankaraffa and others added 11 commits September 9, 2024 09:03
@bryankaraffa
fix: PR test. use separate ds_toplevel_billing_centers. fix param o…
8a48602 
…rder
@bryankaraffa
feat: add RI + SP recommended PTs
237f569
@bryankaraffa
feat: only recommend flexera PTs if >=1 public cloud bill connect
0f90696
@bryankaraffa
feat: add classification/sorting...
4410911 
not convinced "severity" is the right dimension for this... considering maybe aligning to the FinOps Framework "Domains" and grouping based on that
@bryankaraffa
fix: case-insensitive match for credential lookup in create applied p…
7f39f45 
…olicy
@bryankaraffa
feat: add Create Service Account action
e1b9ab3
@bryankaraffa
task: change to 15 minute frequency
f367c97
@bryankaraffa
feat: refactor. Use incident results from other PTs. Improve Error Po…
935dbb6 
…licy formatting.
@bryankaraffa
feat: improved check details with links to Flexera Docs
d557376
@bryankaraffa @nia-vf1
fix: spacing
3eed05f 
Co-authored-by: nia-vf1 <[email protected]>
@bryankaraffa
fix: use "gcp" for google bill connect lookup
9021cea
@bryankaraffa bryankaraffa force-pushed the feat/POL-1298_new_pt_flexera_onboarding branch from 61c646a to 9021cea Compare September 9, 2024 16:04
@bryankaraffa bryankaraffa requested a review from a team November 7, 2024 22:47
nia-vf1
nia-vf1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@nia-vf1 nia-vf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nia-vf1 nia-vf1 nia-vf1 approved these changes

Assignees

@bryankaraffa bryankaraffa

Labels
enhancement New feature or request New Policy READY-FOR-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryankaraffa @nia-vf1