Added ImageViewer Control feature #960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking on status of getting this PR merged.. Everything was updated 3 months ago and the Control should be working without a hitch. I don't think it needed any tweaks, but feel free to review in case there's something that needs cleaning up before making official.. |
|
Closing as stale. Re-open and resolve conflicts if decide to work on this PR further. |
|
Hello, is this ready to use now? I can't find it anywhere in the code or documentation. |
|
I created another Pull Request at #2248 with the updated commit. Hopefully I did everything right and there's no problems with it, but if you see anything to be fixed or improved, please do. I'm not able to compile and test it, but pretty sure it'll work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #943
Regarding Issue #617