Skip to content

Commit

Permalink
Fix incorrect source in device mapping REST API docs (#25641)
Browse files Browse the repository at this point in the history
### Summary

This PR closes #25640 by fixing the incorrect `source` value in the
device mapping REST API docs.

The real value is `mdm_idp_accounts` which can be found
[here](https://github.com/fleetdm/fleet/blob/15ac79323858c7344677edd5eb01b9a0d548120f/server/fleet/hosts.go#L894).

### Test Plan

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.

I couldn't find any other references to `identity_provider`, so I think
these two were all of them.
  • Loading branch information
jordan-wright authored Jan 24, 2025
1 parent 2589092 commit d074ba2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changes/25640-fix-idp-source
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixes incorrect source value in device mapping REST API documentation
4 changes: 2 additions & 2 deletions docs/REST API/rest-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3468,7 +3468,7 @@ Note that IdP email is only supported on macOS hosts. It's collected once, durin
"device_mapping": [
{
"email": "[email protected]",
"source": "identity_provider"
"source": "mdm_idp_accounts"
},
{
"email": "[email protected]",
Expand Down Expand Up @@ -3519,7 +3519,7 @@ Updates the email for the `custom` data source in the human-device mapping. This
"device_mapping": [
{
"email": "[email protected]",
"source": "identity_provider"
"source": "mdm_idp_accounts"
},
{
"email": "[email protected]",
Expand Down

0 comments on commit d074ba2

Please sign in to comment.