Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add performance tests #384

Merged
merged 25 commits into from
Aug 18, 2024
Merged

Add performance tests #384

merged 25 commits into from
Aug 18, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Jul 28, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (817b2e0) to head (5e71492).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          62       62           
  Lines       10331    10331           
=======================================
  Hits         9083     9083           
  Misses       1248     1248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P Amir-P requested a review from amantoux July 28, 2024 12:53
amantoux
amantoux requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Amir-P for putting this in place
It looks good to me. I just have one or two comments
I have a general concern: Aren't these tests run on a virtual machine? If it is the case we might observe volatility on the result and possibly false negatives/positives?
Any thoughts on this?

.github/workflows/fleather.yml Outdated
@@ -1,6 +1,10 @@
name: build

on: [push, pull_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it interesting to have the CI being run on a the branch before creating the pull request

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for limiting push to master branch was the duplicated run of CI on PR but I think using push as trigger would solve it and enable running CI on every branch without PR too. I'll test it.

.github/workflows/performance_test.yaml Outdated Show resolved Hide resolved
@Amir-P
Copy link
Member Author

Amir-P commented Aug 2, 2024 •
edited
Loading

I talked to Alan outside of GitHub, and we decided to keep it as is but improve it in future for more streamlined local performance test run. We can also run on master and the current HEAD in the same virtual machine to have more realistic and stable performance tests (and maybe run multiple times and average the values).

amantoux
amantoux approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, let me know your thought

.github/workflows/fleather.yml Outdated Show resolved Hide resolved
amantoux
amantoux approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amir-P Amir-P mentioned this pull request Aug 9, 2024
Closed
@Amir-P Amir-P force-pushed the chore/add_performance_tests branch 2 times, most recently from 28de4e7 to b34423f Compare August 11, 2024 19:10
@Amir-P Amir-P force-pushed the chore/add_performance_tests branch from b34423f to a3150a3 Compare August 11, 2024 19:14
@Amir-P Amir-P force-pushed the chore/add_performance_tests branch from 445ad7e to 5662616 Compare August 16, 2024 13:51
@Amir-P Amir-P requested a review from amantoux August 16, 2024 14:00
@Amir-P Amir-P mentioned this pull request Aug 16, 2024
Merged
amantoux
amantoux reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in place
I have a tiny comment

packages/fleather/example/pubspec.yaml Show resolved Hide resolved
@amantoux amantoux merged commit 7f965d0 into master Aug 18, 2024
4 checks passed
@Amir-P Amir-P deleted the chore/add_performance_tests branch August 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amir-P @amantoux