Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document MapPosition/PositionCallback.hasGesture in-code #1973

Merged
merged 5 commits into from
Oct 3, 2024
Merged

chore: document MapPosition/PositionCallback.hasGesture in-code #1973

merged 5 commits into from
Oct 3, 2024

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Oct 1, 2024 •
edited
Loading

Changes:

  • Document MapPosition.hasGesture
  • Template the MapPosition.hasGesture documentation and use in PositionCallback to describe the additional argument

@alestiago alestiago force-pushed the alestiago/document-has-gesture branch from ab38a80 to 311907e Compare October 1, 2024 10:08
josxha
josxha approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @alestiago!

JaffaKetchup
JaffaKetchup approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! There was documentation for this somewhere, but I do remember it being difficult to find, and I'm not sure if it still exists :)

@JaffaKetchup JaffaKetchup changed the title docs: document hasGesture chore: document MapPosition/PositionCallback.hasGesture in-code Oct 3, 2024
@JaffaKetchup JaffaKetchup merged commit d73d2f1 into fleaflet:master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josxha josxha josxha approved these changes

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alestiago @josxha @JaffaKetchup