fix: eagerly listen to TileLayer.reset stream to ensure handler is fired
#1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added refreshing of reset listener when reset stream changes within widget lifecycle
josxha
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Nice pull request @JaffaKetchup!👍Added two small comments.
Could be nice to have a test for this, but no pressure. 😄
|
We can add a more detailed test for the pruning etc. logic when #1813 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added refreshing of reset listener when reset stream changes within widget lifecycle.
Fixes #1808. However, the behaviour is still not correct, because the tile loading logic is incorrect. This looks like #1813:
urlTemplatedoes not change, tiles are evicted but not loaded until the map is moved (and possibly the tiles are not evicted correctly because they appear to reload quickly, so maybe from cache, butresetshould empty cache)urlTemplatedoes change, tiles are evicted but then instantly reloaded (see above), and new tiles load in gradually replacing/overlaying the old ones - the old tiles should not become visible in-betweenTherefore, this will need a follow up PR.