Changed TileLayer's default (native) zoom levels
#1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made min and max native zoom levels non-nullable Improved and corrected documentation Improved internal `_clampToNativeZoom` implementation
JaffaKetchup
changed the title
TileLayer's defaults for zoom levelsTileLayer's default (native) zoom levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1625.
The issue was already apparently resolved in v6 'master', however, it did not appear that way due to a likely conflict between the default
maxZoomand specifiedmaxNativeZoom, where themaxZoom's effect took priority.Changes have been made to the defaults, as follows:
minZoom: 0maxZoom: double.infinityminNativeZoom: 0 (non-nullable)maxNativeZoom: 19 (non-nullable)Changes have also been made to the documentation to reflect more appropriate usage recommendations and remove/correct confusing information.
The internal
_clampToNativeZoomimplementation has also been massively simplified to use Dart's nativeclampmethod.