Replace CustomPoint with extension methods on Point #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
requested changes
Jul 16, 2023
|
Nice catch on the redundant imports @JaffaKetchup ! First I started by removing the For that reason I've updated the imports to: import 'dart:math' as math hide Point;
import 'dart:math' show Point;WDYT? |
|
It's less than ideal, I'm sure you'll agree, but OK for now! |
JaffaKetchup
requested review from
JaffaKetchup,
ibrierley,
TesteurManiak and
mootw
JaffaKetchup
approved these changes
Jul 18, 2023
rorystephenson
force-pushed
the
replace-custom-point-with-extension-methods-on-point
branch
from
02bf67b
to
3471c44
Compare
The CustomPoint class predates dart extension methods. The name is confusing (custom in what sense, and why) and in looking at the implementation it became clear that it was essentially just adding extension methods. Changing to a Point will avoid conversions in plugins which deal with libraries that use Point. Code will work as-is without changes with the exception of the subtraction operator. Previously CustomPoint<int> - CustomPoint<double> did not trigger analyzer warnings but would cause a runtime exception. This is now replaced by subtract() extension methods which allow subtracting num from a Point<double> and int from Point<int>.
Co-authored-by: 6y <[email protected]>
rorystephenson
force-pushed
the
replace-custom-point-with-extension-methods-on-point
branch
from
3471c44
to
c1545dc
Compare
rorystephenson
deleted the
replace-custom-point-with-extension-methods-on-point
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CustomPoint class predates dart extension methods. The name is confusing (custom in what sense, and why) and in looking at the implementation it became clear that it was essentially just adding extension methods.
Changing to a Point will avoid conversions in plugins which deal with libraries that use Point.
Code will work as-is without changes with the exception of the subtraction operator. Previously CustomPoint - CustomPoint did not trigger analyzer warnings but would cause a runtime exception. This is now replaced by subtract() extension methods which allow subtracting num from a Point and int from Point.
Issue #1522 prompted me to look at this and I believe it resolves that issue (we no longer add methods which are not runtime-safe to Point and Point already documents the potential runtime error with the * operator).
Note that the vast majority of changes are just renaming CustomPoint to Point and importing it.