Skip to content

Overdue Bugfixes

Compare
Choose a tag to compare
@zhiayang zhiayang released this 04 Oct 17:13
· 1719 commits to 906977ab65d862ba1470a31ba54fd8fbcbb410b7 since this release
  1. When lexer errors are encountered (missing quotes or invalid tokens), we used to throw a warning:
    attempting to lex file while file is already being lexed, stop it. That happens because we want to print the context, which requires reading the file, which happens to read the tokens, which... etc. etc. We've just fixed it by returning the current state if we request file contents while lexing.

  2. Types were not usable from imported modules. Anything that required fetching the SST node of a given fir::Type would not work if the type in question was defined in an imported module. I guess we didn't have a test case for this, but the main issue was that the typeDefnMap of imported modules was not actually copied to the importing module.
    Fixed by a small refactor.