data: Remove unnecessary Qt annotations for vardicts #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sodivad
reviewed
Nov 13, 2024
Sodivad
approved these changes
Nov 13, 2024
swick
force-pushed
the
wip/qt-annotations
branch
from
26f07ea
to
5598253
Compare
|
Forgot that the first commit already added missing annotations and removed the vardict ones. Split them into two commits, one removing vardict annotations, one adding the missing annotations. Sorry for the noise. |
|
Ack. |
swick
force-pushed
the
wip/qt-annotations
branch
from
5598253
to
4338fb1
Compare
GeorgesStavracas
approved these changes
Nov 28, 2024
GeorgesStavracas
force-pushed
the
wip/qt-annotations
branch
from
4338fb1
to
a342d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @davidedmundson @Sodivad
Trying to continue the work from #1352