Fixes for GUnixFDList related issues #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahl
reviewed
Nov 5, 2024
|
@jadahl ping |
|
lgtm |
This also makes sure the selection_read_done won't crash when the backend call fails.
This allows passing in a GVariant and GUnixFDList directly from the DBus APIs without having to do pre condition checking in the caller.
Mostly by assining to an owning g_autofd variable. It also makes sure the variables get cleared to -1 where applicable. This also includes a change to take a lock before accessing the data protected by the lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.