Use g_auto and G_VARIANT_BUILDER_INIT for all GVariantBuilders #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsparber
reviewed
Nov 4, 2024
jsparber
reviewed
Nov 4, 2024
swick
force-pushed
the
wip/gvariant-builder-auto
branch
from
9821ba2
to
87fc06c
Compare
|
Dropped BUILDER_INIT_UNSET and its usage. |
the commit is still there. |
swick
force-pushed
the
wip/gvariant-builder-auto
branch
from
87fc06c
to
b498b6f
Compare
|
Woops, my bad. |
GeorgesStavracas
approved these changes
Nov 5, 2024
If it is missing, we just don't add it to the keyfile instead of running into criticals. The XdpAppInfo impl can still add the right command later on.
One has to be very careful about the control flow and early exits without the g_auto which can easily result in memory leaks. I noticed at least 5 cases where the change does fix a leak, even though it might be a bit hard to trigger. This also makes sure that all g_auto usages are initialized correctly.
GeorgesStavracas
force-pushed
the
wip/gvariant-builder-auto
branch
from
b498b6f
to
65eb753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always initialize g_auto(GVariantBuilder)
Use g_auto and G_VARIANT_BUILDER_INIT for all GVariantBuilders
One has to be very careful about the control flow and early exits
without the g_auto which can easily result in memory leaks. I noticed at
least 5 cases where the change does fix a leak, even though it might be
a bit hard to trigger.
This also makes sure that all g_auto usages are initialized correctly.