Release workflow improvements #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Found an issue |
Noticed while releasing 1.19.0. The release workflow first updates PO files, then builds xdg-desktop-portal. Which means, if something goes wrong with the tests, we'll already have committed something to the main branch. Push translations after building.
This makes it easy to spot a release point in the commit history.
So we can see what it's going to do in dry runs.
Make dry runs do everything a regular run would do, except it doesn't *actually* push nor publish anything. It still extracts release info, updates PO files, etc.
This should make things a bit tighter.
GeorgesStavracas
force-pushed
the
gbsneto/release-workflow-improvements
branch
from
4183a17
to
25842d0
Compare
|
Okay, I see the issue and the changes make sense. So, still LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.