data: Document the session_handle type mismatch #1408
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
same is also true for location portal |
|
@bilelmoussaoui which call? I'm looking at |
whot
force-pushed
the
wip/document-session-handle-bug
branch
from
ffa25b7
to
173b311
Compare
|
Updated - still convinced the location portal is fine :) |
|
lgtm, will merge in some days if noone objects |
This was erroneously implemented as `s` but for backwards compatibility cannot be changed as it would break existing clients. Best we can do here is fix the documentation and tell people about it. See eebb041 ("use correct type for the session object path") and its revert in e452353. Closes flatpak#1359
jadahl
force-pushed
the
wip/document-session-handle-bug
branch
from
173b311
to
8f03780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was erroneously implemented as
sbut for backwards compatibility cannot be changed as it would break existing clients. Best we can do here is fix the documentation and tell people about it.See eebb041 ("use correct type for the session object path") and its revert in e452353.
Closes #1359