file-transfer: return a value from task #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hfiguiere
commented
Oct 11, 2023
hfiguiere
commented
- This fixes "GTask finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program." errors.
hfiguiere
force-pushed
the
g_task_return
branch
from
6355910
to
11d2b5e
Compare
jadahl
reviewed
Oct 11, 2023
document-portal/file-transfer.c
Outdated
|
|
||
| task = g_task_new (NULL, NULL, NULL, NULL); | ||
| g_task_set_name (task, name); |
There was a problem hiding this comment.
This is unrelated to what the commit message describes this commit to be doing.
There was a problem hiding this comment.
In addition to splitting this in a separate commit, it would be lovely to have the GTask set a source tag, and assert it in stop_file_transfers_in_thread_func as well
There was a problem hiding this comment.
I have removed them from this PR.
GeorgesStavracas
requested changes
Oct 11, 2023
document-portal/file-transfer.c
Outdated
|
|
||
| task = g_task_new (NULL, NULL, NULL, NULL); | ||
| g_task_set_name (task, name); |
There was a problem hiding this comment.
In addition to splitting this in a separate commit, it would be lovely to have the GTask set a source tag, and assert it in stop_file_transfers_in_thread_func as well
- This fixes "GTask finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program." errors.
hfiguiere
force-pushed
the
g_task_return
branch
from
11d2b5e
to
471b2ce
Compare
GeorgesStavracas
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.