docs: Clarify PrepareInstall response #1088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was missing the icon field + mentioning it would always return a value even if the used doesn't set the editable icon / editable name options
ebassi
requested changes
Aug 28, 2023
| @@ -153,7 +153,13 @@ | |||
| <varlistentry> | |||
| <term>name s</term> | |||
| <listitem><para> | |||
| The name chosen by the user for the launcher. | |||
| The name chosen by the user for the launcher or the predefined one. | |||
There was a problem hiding this comment.
Suggested change
| The name chosen by the user for the launcher or the predefined one. | |
| The name chosen by the user for the launcher, or the predefined one. |
Also: who chooses the "predefined" name? The portal implementation? The host?
There was a problem hiding this comment.
The caller of PrepareInstall can pass name/icon and they can edited by the user if the call to PrepareInstall allows them to
There was a problem hiding this comment.
So not sure if predefined is the correct wording
| <varlistentry> | ||
| <term>icon v</term> | ||
| <listitem><para> | ||
| The icon chosen by the user for the launcher or the predefined one. |
There was a problem hiding this comment.
Suggested change
| The icon chosen by the user for the launcher or the predefined one. | |
| The icon chosen by the user for the launcher, or the predefined one. |
Same as above: who chooses the predefined icon?
GeorgesStavracas
added
documentation
portal: dynamic launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was missing the icon field + mentioning it would always return a value even if the used doesn't set the editable icon / editable name options