notification: Always set error in the failure case

flatpak · Nov 5, 2024 · 6362361 · 6362361
1 parent 4a2abe2
commit 6362361
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/notification.c b/src/notification.c
@@ -806,7 +806,13 @@ parse_serialized_sound (GVariantBuilder  *builder,
         }
 
       if (!xdp_validate_sound (sealed_sound))
-        return FALSE;
+        {
+          g_set_error_literal (error,
+                               XDG_DESKTOP_PORTAL_ERROR,
+                               XDG_DESKTOP_PORTAL_ERROR_INVALID_ARGUMENT,
+                               "Invalid sound: The sound data is invalid");
+          return FALSE;
+        }
 
       fd_sound = xdp_sealed_fd_to_handle (sealed_sound,
                                           out_fd_list,