feat: add copy button to terminal commands #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronanru
changed the title
ronanru
changed the title
|
Wow, that's great! @jimmac @barthalion Any chance you could review this PR? Thanks! |
|
Looks good to me. |
|
Can't really comment on the code, but in terms of improved experience, it's good. |
|
@razzeee Is it ok to merge this? I am not sure whether the Flathub setup page is manually copied from the Flatpak.org quick setup page or if there is some automatic script involved. |
|
Don't worry about the flathub site, it's a manual process right now and I can take care of breakage. |
|
Thanks! Let's merge this. :-) |
razzeee
reviewed
Dec 1, 2023
| </code></pre> | ||
| <terminal-command> | ||
| echo -e 'sys-apps/flatpak ~amd64\nacct-user/flatpak ~amd64\nacct-group/flatpak ~amd64\ndev-util/ostree ~amd64' >> /etc/portage/package.accept_keywords/flatpak | ||
| </terminal-commande> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a copy button to all terminal commands.
distro.ymlfile already had a lot of repeating html so instead of adding a button to each command there I added a custom component<terminal-command>that adds a button and a dollar sign before every line on page load.