-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[obsolete] Update sampling output window #32
Conversation
I don't know much about the state of javascript testing, but I would feel a lot better if we had some tests on the ess/rhat functions at least. They're famously tricky. For example, I just did a run where this is what is reported in the UI:
Downloading the draws and then splitting into four csvs before feeding to
Ideally these would agree. I think a package which implemented these MCMC diagnostics and tested them against Stan's implementation would be a great service to the broader ecosystem, so it is probably worth pulling them out |
@WardBrian I agree. I propose we first make sure everything is good in bayes_kit in Python, and then match it exactly in .js, with tests. I did this with ess_imse for mcmc-monitor and ported the code over to stan-playground. But I'm sure it needs to be revisited (IDK if bayes_kit was finalized at that point) |
Momentum on the bayes-kit project has pretty much stalled. The tests in Stan's C++ have also been used in e.g. the Rust mcmc package, but porting them to this environment may be a bit annoying |
replaced by #46 |
This is a redo of #21
I took all those changes and put them on top of the new chain of changes - since the file sharing has been revamped.
See the discussion in the other PR. I think there are still some things to check/improve, but I think it would be great to merge this for now.