Normalize newlines before passing to scripts #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
jsoules
approved these changes
Dec 4, 2024
|
Addresses #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: https://discourse.mc-stan.org/t/stan-playground-issues-with-pasting-scripts/37498
WebR complains about invalid tokens if given windows CRLF line endings. The easiest way to test this on non-windows is save a file in your editor using these endings, and then use the load project window to upload it (copy-pasting seems to remove them, on my Ubuntu machine at least)
I looked through the Monaco docs to see if there was a way we could ask it to do this normalization for us, but it seems there isn't, so I just put it right before we actually shell out to webr or pyodide (pyodide doesn't seem to mind either way)