Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to download 'takeout scripts' #245

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

WardBrian
Copy link
Collaborator

Closes #179

Currently has a working Python script, needs R and probably a better UI

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much commentary you're looking for at this point, but I saw the draft and wanted to make sure you feel seen and heard

@@ -0,0 +1,27 @@
def rename_sampling_options(k):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this only renames one option at a time.

Comment on lines +7 to +16
if k == "init_radius":
return "inits"
if k == "num_warmup":
return "iter_warmup"
if k == "num_samples":
return "iter_sampling"
if k == "num_chains":
return "chains"
if k == "seed":
return "seed"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I want this to be a dictionary, but I think I actually just want Python to be Typescript.

gui/src/app/Scripting/Runtime/load_args.py Show resolved Hide resolved
.join("\n");
};

const makePyRuntimeScript = (project: ProjectDataModel) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of code is always going to be pretty ugly to write, but when you're ready to take this out of draft we can chat about whether there's anything to be done with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional shim code when downloading a project with scripts
2 participants