Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate data origin #236

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Indicate data origin #236

merged 3 commits into from
Nov 4, 2024

Conversation

WardBrian
Copy link
Collaborator

Closes #228.

I put this bit of data in the meta field, but made it optional, and excluded it from most of the serialization (e.g., there's no way to set it by a query parameter). Missing is the same as "user provided" data.

image

@WardBrian WardBrian requested a review from jsoules October 30, 2024 20:53
@jsoules
Label case where data is from a prior version of generator script. (#237
fa1c0e9 
)

* Label stale data from prior generator-script versions.

* Ensure exhaustive check for describing data source type. Add color.

* Remove central list of warning-sources; include color and msg logic in same switch.
jsoules
jsoules approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@WardBrian WardBrian merged commit 5c88cc6 into main Nov 4, 2024
2 checks passed
@WardBrian WardBrian deleted the indicate-data-origin branch November 4, 2024 15:21
@WardBrian WardBrian mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoules jsoules jsoules approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visually indicate if data came from one of the generation scripts
2 participants
@WardBrian @jsoules