Compile Model button and CompileContextProvider #191
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { createContext } from "react"; | ||
|
|
||
| export type CompileStatus = | ||
| | "preparing" | ||
| | "compiling" | ||
| | "compiled" | ||
| | "failed" | ||
| | ""; | ||
|
|
||
| type CompileContextType = { | ||
| compileStatus: CompileStatus; | ||
| compileMessage: string; | ||
| compiledMainJsUrl?: string; | ||
| validSyntax: boolean; | ||
| compile: () => void; | ||
| setValidSyntax: (valid: boolean) => void; | ||
| stanWasmServerUrl: string; | ||
| setStanWasmServerUrl: (url: string) => void; | ||
| }; | ||
|
|
||
| export const CompileContext = createContext<CompileContextType>({ | ||
| compileStatus: "", | ||
| compileMessage: "", | ||
| validSyntax: false, | ||
| compile: () => {}, | ||
| setValidSyntax: () => {}, | ||
| stanWasmServerUrl: "", | ||
| setStanWasmServerUrl: () => {}, | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| import { ProjectContext } from "@SpCore/ProjectContextProvider"; | ||
| import compileStanProgram from "@SpCompileContext/compileStanProgram"; | ||
| import { | ||
| FunctionComponent, | ||
| PropsWithChildren, | ||
| useCallback, | ||
| useContext, | ||
| useEffect, | ||
| useState, | ||
| } from "react"; | ||
| import { CompileContext, CompileStatus } from "./CompileContext"; | ||
|
|
||
| type CompileContextProviderProps = { | ||
| // none | ||
| }; | ||
|
|
||
| const initialStanWasmServerUrl = | ||
| localStorage.getItem("stanWasmServerUrl") || | ||
| "https://trom-stan-wasm-server.magland.org"; | ||
|
|
||
| export const CompileContextProvider: FunctionComponent< | ||
| PropsWithChildren<CompileContextProviderProps> | ||
| > = ({ children }) => { | ||
| const { data } = useContext(ProjectContext); | ||
| const [compileStatus, setCompileStatus] = useState<CompileStatus>(""); | ||
| const [ | ||
| theStanFileContentThasHasBeenCompiled, | ||
| setTheStanFileContentThasHasBeenCompiled, | ||
| ] = useState<string>(""); | ||
| const [compileMessage, setCompileMessage] = useState<string>(""); | ||
| const [compiledMainJsUrl, setCompiledMainJsUrl] = useState< | ||
| string | undefined | ||
| >(undefined); | ||
| const [validSyntax, setValidSyntax] = useState<boolean>(false); | ||
|
|
||
| useEffect(() => { | ||
| // if the compiled content is not the same as the current content, | ||
| // then the state should not be compiled or failed | ||
| if (data.stanFileContent !== theStanFileContentThasHasBeenCompiled) { | ||
| if (compileStatus === "compiled" || compileStatus === "failed") { | ||
| setCompileStatus(""); | ||
| setCompiledMainJsUrl(""); | ||
| } | ||
| } | ||
| }, [ | ||
| data.stanFileContent, | ||
| theStanFileContentThasHasBeenCompiled, | ||
| compileStatus, | ||
| setCompiledMainJsUrl, | ||
| ]); | ||
|
|
||
| const [stanWasmServerUrl, setStanWasmServerUrl] = useState<string>( | ||
| initialStanWasmServerUrl, | ||
| ); | ||
| useEffect(() => { | ||
| // persist to local storage | ||
| localStorage.setItem("stanWasmServerUrl", stanWasmServerUrl); | ||
| }, [stanWasmServerUrl]); | ||
|
Comment on lines
+55
to
+58
There was a problem hiding this comment. Not sure I understand why we need to persist this to local storage vs. it being part of the context? There was a problem hiding this comment. When user refreshes the page, or closes the tab and comes back later, we want this to remember the choice. There was a problem hiding this comment. (this is also the current behavior, the code just moved in this PR) |
||
|
|
||
| const handleCompile = useCallback(async () => { | ||
| setCompileStatus("compiling"); | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); // for effect | ||
| const onStatus = (msg: string) => { | ||
| setCompileMessage(msg); | ||
| }; | ||
| const { mainJsUrl } = await compileStanProgram( | ||
| stanWasmServerUrl, | ||
| data.stanFileContent, | ||
| onStatus, | ||
| ); | ||
|
|
||
| if (!mainJsUrl) { | ||
| setCompileStatus("failed"); | ||
| return; | ||
| } | ||
| setCompiledMainJsUrl(mainJsUrl); | ||
| setCompileStatus("compiled"); | ||
| setTheStanFileContentThasHasBeenCompiled(data.stanFileContent); | ||
| }, [ | ||
| data.stanFileContent, | ||
| setCompiledMainJsUrl, | ||
| setCompileStatus, | ||
| stanWasmServerUrl, | ||
| ]); | ||
|
|
||
| return ( | ||
| <CompileContext.Provider | ||
| value={{ | ||
| compileStatus, | ||
| compileMessage, | ||
| compiledMainJsUrl, | ||
| validSyntax, | ||
| compile: handleCompile, | ||
| setValidSyntax, | ||
| stanWasmServerUrl, | ||
| setStanWasmServerUrl, | ||
| }} | ||
| > | ||
| {children} | ||
| </CompileContext.Provider> | ||
| ); | ||
| }; | ||
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worthwhile to do the flip side of this--such that if the
stanFileContentis flipped back to equal the content that has been compiled, we revert to the "compiled" state?I'm imagining deleting and re-adding a semicolon for instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote against that because (a) it would be challenging to manage that -- you see in this code the compiledMainJsUrl gets cleared (b) it's easy enough to click the compile button again, and it will be a cache hit.