Use MUI for connection controls #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoules
reviewed
Jul 31, 2024
gui/src/app/CompilationServerConnectionControl/ConfigureCompilationServerDialog.tsx
Outdated
Show resolved
Hide resolved
jsoules
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Two other thoughts to consider:
- There's some weird spacing issues with the "retry" link: vertically, because of the hidden underline, and horizontally, it falls a little too close to the connection status text. I'd consider bumping that out, and possibly just using a
Buttoninstead of aLink. - If possible, it might be nice to find a way to display the URLs for the public/local connection compilation server. Not a deal-breaker.
I'd be happy to merge this even if you didn't address those, however.
|
Updated screenshot: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #178, this addresses the couple of my comments that were deferred