Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm before unload if unsaved changes #177

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Confirm before unload if unsaved changes #177

merged 2 commits into from
Jul 30, 2024

Conversation

WardBrian
Copy link
Collaborator

Closes #173

jsoules
jsoules approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the expected behavior is to cause a standard popup for navigation events away from the page (incl. closing or refreshing the tab), but does not affect loading an example, etc.

I think this does what it intends to do and should be included.

@WardBrian WardBrian merged commit b76447b into main Jul 30, 2024
2 checks passed
@WardBrian WardBrian deleted the are-you-sure branch July 30, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoules jsoules jsoules approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“Are you sure” before exiting or re-loading with dirty state
2 participants
@WardBrian @jsoules