Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolbar, smarter hiding of labels #170

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

WardBrian
Copy link
Collaborator

This is an alternative to #168

Prior:
image

Now:
image

Main differences are centering the items and some clever CSS to automatically hide the text labels when the container gets too small. This replaces the useMediaQuery hook in StanEditor, which didn't quite work anyway

@magland
Copy link
Collaborator

magland commented Jul 29, 2024

Looks great!

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions. I think this is good.

I wonder if, when the icon labels are hidden, we can get a tighter spacing on the resulting icon-buttons; they seem like they stay pretty far apart?

gui/src/app/FileEditor/TextEditor.tsx Outdated Show resolved Hide resolved
gui/src/app/FileEditor/TextEditor.tsx Outdated Show resolved Hide resolved
@WardBrian
Copy link
Collaborator Author

Icons are much tighter when collapsed now:

image

@WardBrian WardBrian merged commit 07586d1 into main Jul 29, 2024
2 checks passed
@WardBrian WardBrian deleted the editor-toolbar-cleanup branch July 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants