-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove position computations, use MUI components and new splitter #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple possible tweaks. Overall I think it looks good, but will want to take a deeper look on Monday.
Overall this looks good to me. I think the top bar takes up too much vertical space now. This causes challenging conflicts with #127 (and maybe #132 as well). I started to look at it but it wasn't going smoothly. How do you propose we deal with that? Since those involve tab widgets, I think it would have been better if we had merged those first. Do you think it's reasonable to merge those and then apply the changes of this PR? Or other way around? |
Yeah, I realized as I was going it would cause some conflicts going either way. I am willing to do the merge resolution on whichever one doesn’t go first, but I don’t have a strong opinion on the ordering there |
That would be great if you are willing to do that, because I was getting confused in my attempt. :) |
I tested this out and I think the changes all look good, except IMO the title bar has too much vertical space. |
@magland -- I've updated the top bar to use MUI's |
Okay I think it's still too big, but it's not a huge deal and I wouldn't want to block the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have anything further on this, if you're happy with it.
I initially intended only to address #71 (comment), but maintaining our current layout quickly led me to use some more MUI components and remove the absolute positioning. Apologies for the monolithic PR
My goal was not to change any layouts or functionality, though some visual features have changed, mostly due to using MUI more