Don't cache data contents in script state

flatironinstitute · Nov 4, 2024 · e9c2579 · e9c2579
1 parent 7b7e63d
commit e9c2579
Showing 1 changed file with 15 additions and 28 deletions.
diff --git a/gui/src/app/Scripting/DataGeneration/useDataGenState.ts b/gui/src/app/Scripting/DataGeneration/useDataGenState.ts
@@ -10,37 +10,24 @@ const useDataGenState = (source: "python" | "r") => {
   const [status, setStatus] = useState<InterpreterStatus>("idle");
   const consoleRef = useRef<HTMLDivElement>(null);
 
-  const { data, update } = useContext(ProjectContext);
+  const { update } = useContext(ProjectContext);
 
-  // we don't want the callback to force itself to re-render when data is set
-  const lastData = useRef(data.dataFileContent);
   const onData = useCallback(
     (newData: unknown) => {
-      const dataJson = JSON.stringify(newData, null, 2);
-
-      if (dataJson !== lastData.current) {
-        lastData.current = dataJson;
-        update({
-          type: "generateData",
-          content: dataJson,
-          dataSource:
-            source === "python"
-              ? DataSource.GENERATED_BY_PYTHON
-              : DataSource.GENERATED_BY_R,
-        });
-        // Use "stan-playground" prefix to distinguish from console output of the running code
-        writeConsoleOutToDiv(
-          consoleRef,
-          "[stan-playground] Data updated",
-          "stdout",
-        );
-      } else {
-        writeConsoleOutToDiv(
-          consoleRef,
-          "[stan-playground] Data unchanged",
-          "stdout",
-        );
-      }
+      update({
+        type: "generateData",
+        content: JSON.stringify(newData, null, 2),
+        dataSource:
+          source === "python"
+            ? DataSource.GENERATED_BY_PYTHON
+            : DataSource.GENERATED_BY_R,
+      });
+      // Use "stan-playground" prefix to distinguish from console output of the running code
+      writeConsoleOutToDiv(
+        consoleRef,
+        "[stan-playground] Data updated",
+        "stdout",
+      );
     },
     [update, consoleRef],
   );