Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify dependency version requirements, check for older cufinufft #93

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Clarify dependency version requirements, check for older cufinufft #93

merged 1 commit into from
Oct 23, 2023

Conversation

WardBrian
Copy link
Collaborator

This does a few small things:

  • passes -v to the docs build CI to make progress easier to monitor
  • links to the documentation in the README
  • Clarifies that the currently released finufft is actually fine, its cufinufft which is unreleased
  • Puts a bound on finufft's version in our project metadata
  • Checks for cufinufft's version at runtime and refuses to use 1.x

eickenberg
eickenberg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@eickenberg eickenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WardBrian WardBrian merged commit 5797cac into main Oct 23, 2023
5 checks passed
@WardBrian WardBrian deleted the cleanup/dependency-versions branch October 23, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eickenberg eickenberg eickenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WardBrian @eickenberg