Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function wrappers around .apply #89

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Add function wrappers around .apply #89

merged 2 commits into from
Oct 17, 2023

Conversation

WardBrian
Copy link
Collaborator

Closes #84. Following the guidance in the Pytorch documentation, we provide a function which just calls .apply on the associated Function class.

@WardBrian WardBrian requested a review from eickenberg October 17, 2023 14:22
@WardBrian
Copy link
Collaborator Author

(the thing I'm doing next is doc, which this also helps with - autodoc on a torch.autograd.Function subclass is not very helpful!)

@WardBrian WardBrian force-pushed the ref/functional-wrappers branch from f92ca00 to 8819feb Compare October 17, 2023 16:49
@WardBrian WardBrian mentioned this pull request Oct 17, 2023
Merged
eickenberg
eickenberg approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@eickenberg eickenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, that makes it look much more like the torch nn functional methods

@WardBrian WardBrian merged commit 020842c into main Oct 17, 2023
4 checks passed
@WardBrian WardBrian deleted the ref/functional-wrappers branch October 17, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eickenberg eickenberg eickenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should not need to call .apply on our functional.finufft_type* functions
2 participants
@WardBrian @eickenberg