Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Github Actions #60

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Clean up Github Actions #60

merged 6 commits into from
Oct 4, 2023

Conversation

WardBrian
Copy link
Collaborator

Closes #49

@WardBrian WardBrian added the github_actions Pull requests that update GitHub Actions code label Oct 4, 2023
@WardBrian WardBrian linked an issue Oct 4, 2023 that may be closed by this pull request
MAINT audit requirements.txt #61
Closed
eickenberg
eickenberg reviewed Oct 4, 2023
View reviewed changes
pytorch_finufft/_err.py
) -> None:
# raise ValueError("Not yet implemented!")

dimension = len(points_tuple)
# dimension = len(points_tuple)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the "type3" code is currently unused

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@WardBrian WardBrian requested a review from eickenberg October 4, 2023 15:46
@WardBrian
Copy link
Collaborator Author

Tests are running and mostly passing but it looks like we have some tolerance issues

eickenberg
eickenberg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@eickenberg eickenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM except I have no idea about the changes to the yaml/toml files. I guess I'll ask you for a gist of those changes when we start

@WardBrian WardBrian merged commit d8a8e4b into main Oct 4, 2023
0 of 4 checks passed
@WardBrian WardBrian deleted the fix/ci branch October 4, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eickenberg eickenberg eickenberg approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT audit requirements.txt MAINT CI isn't working :(
2 participants
@WardBrian @eickenberg