-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reparametrize raisedcosine #50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 94.88% 95.04% +0.16%
==========================================
Files 10 10
Lines 840 868 +28
==========================================
+ Hits 797 825 +28
Misses 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty much good to me! Some small changes scattered throughout, and then the following things I think we should discuss:
- Basis docstrings. I think they should have a line or two before parameters that describe what the basis looks like and when you would use them. E.g., do they tile uniformly, are they each about the same size, what types of variables make sense (visual input, head direction, etc.). And then the footnote to references belongs in those lines (it looks weird in the docstring in jupyter or whatever to have the link right at the top). This is probably out-of-scope for this PR, in which case we should open an issue for it.
- We need an explanation of the particularities of the different parameters for the Raised Cosine parameters. Much of that will end up in our separate repo, but we need some here. Do we want to hold off on that until we've worked through it in the separate repo and then add something here? (in which case, we should open an issue)
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
…tute/nemos into reparametrize_raisedcosine
I changed the code so that the peak location is computed so that the decay to zero of the last basis element happens as late as possible. this is not equivalent to what we had before, (it would be if i use |
# - as the time_scaling tends to inf, basis will be small and dense around 0 and | ||
# progressively larger and less dense towards 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# - as the time_scaling tends to inf, basis will be small and dense around 0 and | |
# progressively larger and less dense towards 1. | |
# - as the time_scaling tends to inf, basis will be small and dense around 0 and | |
# progressively larger and less dense towards 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me!
This edits introduce a one extra hyper-parameters for initializing the linear raised cosine bumps, and an two one for the log-raised cosines: