-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glm class restructure #41
Conversation
…pe specific docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only the small changes we've already talked about.
…nemos into glm_class_restructure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small typo fixes, then this is ready to go! I think the developer notes and docs will need some more work, but that's a job for a separate PR.
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
…nemos into glm_class_restructure
PR Overview:
In this PR, I aim to:
neurostatslib
package.NoiseModel
abstract class and a concretePoissonNoiseModel
object to implement the log-likelihood and emission probability.Solver
class and various concrete subclasses to set up the optimization problems for different objective functions.GLM
andRecurrentGLM
classes that rely on solver and noise model objects.Review Suggestions:
I recommend starting the review by reading the developer notes 02 to 05 before delving into the code. These notes provide the rationale and a description of how I structured the classes and why.
Thank you in advance for reviewing this.
Cheers,
Edoardo