Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi dim eval basis #275

Merged
merged 33 commits into from
Dec 13, 2024
Merged

Multi dim eval basis #275

merged 33 commits into from
Dec 13, 2024

Conversation

BalzaniEdoardo
Copy link
Collaborator

@BalzaniEdoardo BalzaniEdoardo commented Dec 4, 2024

This PR follows #274, additional edits to the basis for generalizing the behavior and removing the __call__ method.

  • Allow for N-dim inputs for both conv and eval basis
  • Rename the __call__ method of basis to _evaluate
  • Make sure that the notebook exec error break the build (conf.py config)

EDIT:

  • I made the "set_kernel" method public because I am using it in the doc mostly
  • The set_kernel will be removed from Eval basis in PR Set shape basis method #276 (as discussed with @billbrod )

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (2932475) to head (3691356).
Report is 26 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #275   +/-   ##
============================================
  Coverage        96.13%   96.13%           
============================================
  Files               34       34           
  Lines             2507     2507           
============================================
  Hits              2410     2410           
  Misses              97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@billbrod billbrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small tweaks in wording, but otherwise this looks good to go! It's good how straightforward a change this was.

docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
docs/background/basis/plot_01_1D_basis_function.md Outdated Show resolved Hide resolved
src/nemos/basis/_basis.py Outdated Show resolved Hide resolved
src/nemos/basis/_decaying_exponential.py Outdated Show resolved Hide resolved
@BalzaniEdoardo BalzaniEdoardo merged commit b95b4af into development Dec 13, 2024
13 checks passed
@BalzaniEdoardo BalzaniEdoardo deleted the multi_dim_eval_basis branch December 13, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants