-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi dim eval basis #275
Multi dim eval basis #275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #275 +/- ##
============================================
Coverage 96.13% 96.13%
============================================
Files 34 34
Lines 2507 2507
============================================
Hits 2410 2410
Misses 97 97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small tweaks in wording, but otherwise this looks good to go! It's good how straightforward a change this was.
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
…emos into multi_dim_eval_basis
This PR follows #274, additional edits to the basis for generalizing the behavior and removing the
__call__
method.__call__
method of basis to_evaluate
EDIT: