-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix basis properties #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: William F. Broderick <[email protected]>
Co-authored-by: William F. Broderick <[email protected]>
prevent absolute links to docs (except badge)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 97.24% 97.29% +0.05%
==========================================
Files 20 20
Lines 1815 1849 +34
==========================================
+ Hits 1765 1799 +34
Misses 50 50 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to check setters for basis properties. Properties that can be set (using the
set_parames
) are those one that may be used in cross-validation. In particular, the following parameters should be settableShared by all basis:
SplineBasis:
RaisedCosine:
RaisedCosineLog:
OrthExponentialBasis:
The
mode
parameter will be read-only, since most commonly, only one mode of operation will make sense for a specific variable (spike counts input will requiremode="conv"
for example); It will still be possible to cross-validate over different mode of operation by directly cross-validating different basis,