Dev biharmonic #18
Merged
Dev biharmonic #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askhamwhat
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Hi Manas,
Looks good! There are changes in here to helmrouts2d, hfmm2dwrap, lapkernels2d, lfmm2dwrap that look like some basic cleaning. Everything is passing on my machine as well (though stokes does not seem to be part of the standard test suite). If these are all intentional changes, it's good for me. Just figured I'd point them out in case you didn't mean to include them.
Also, I see that the python builds are failing. Don't know what to make of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying inputs and outputs of the biharmonic fmm
Charges are now 2 complex numbers per point
Dipoles are 3 complex numbers per point
On the output side, gradients are 3 complex numbers per point
The stokes FMM has also been tested to work with the updated interfaces
The python interfaces for the biharmonic fmms are still pending