potential way of implementing discussion #587 #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how variables depending on problem dimensionality could be merged into
std::array
s, and how it potentially simplifies the code.This is not yet complete:
nf1, nf2, nf3
tonf123
, since the obvious candidatenf
was already used for storing the productnf1*nf2*nf3
, and I didn't want to do big refactorings for this demonstrations.spreadinterp
, which I haven't looked at much, mostly because there is a clash betweenfinufft_core.h
, where integer quantities are usuallyBIGINT
,andspreadinterp.h
, where they tend to beUBIGINT
. While it is possible to convert individual integers on the fly when crossing the interface, the same does not work forstd::array
s, so I tought I'd ask for opinions before taking this any further.