Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential way of implementing discussion #587 #592

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mreineck
Copy link
Collaborator

This demonstrates how variables depending on problem dimensionality could be merged into std::arrays, and how it potentially simplifies the code.

This is not yet complete:

  • I'm not happy with the variable names yet. For example, I renamed nf1, nf2, nf3 to nf123, since the obvious candidate nf was already used for storing the product nf1*nf2*nf3, and I didn't want to do big refactorings for this demonstrations.
  • there are more good candidates in the interface of spreadinterp, which I haven't looked at much, mostly because there is a clash between finufft_core.h, where integer quantities are usually BIGINT,and spreadinterp.h, where they tend to be UBIGINT. While it is possible to convert individual integers on the fly when crossing the interface, the same does not work for std::arrays, so I tought I'd ask for opinions before taking this any further.

@ahbarnett
Copy link
Collaborator

THanks Martin, THis is a good idea, in the category "incremental simplifications that do not affect performance", right?
Personally, since index arithmetic can product <0 integers, I would switch everything to BIGINT in spreadinterp, if this allows. I'm sure we could bring this in, esp, if it's needed for other simplifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants