Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ``using namespace nda" to Avoid Namespace Pollution #12

Open
wants to merge 1 commit into
base: 1.2.x
Choose a base branch
from

Conversation

yangyu1412
Copy link

@yangyu1412 yangyu1412 commented Dec 11, 2024

Description:

Some header files use using namespace nda. Including these headers in a project can lead to unintended consequences, such as misrecognition of functions in other external libraries as belonging to the nda namespace, which results in compilation errors.

Changes:

  • Removed using namespace nda from header files.
  • Explicitly added nda:: namespace qualification where necessary in the affected code.

Notes:

  • I am currently submitting this PR against the release branch; however, it might be more appropriate to also merge this change into the development branch, but I haven't checked what is in the development branch.
  • If there are alternative suggestions to address this issue without removing using namespace nda, I'm happy to learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant