-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs improvements/typos (MATLAB all kernels; Fortran just Stokes) #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was generated with a slightly newer mwrap (1.1). It compiled fine on my system. @mrachh up to you to keep or revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same story with fmm3d_legacy.c
@ahbarnett The documentation changes look great. For your bullets above:
|
I decided not to pull the documentation change for source vs target sums through the Fortran for now as this would be a larger scale change (and the Fortran docs are not consistent with each other currently). I agree that this should probably be made clear. |
@mrachh you're off the hook for the emfmm3d docs. I put in the formulae. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go for me. @mrachh I put in the formulae for emfmm3d. I left in these newer mwrap generated files. Up to you to revert.
These look great guys. Thanks! @ahbarnett: Did you pull through the docs from the .mw file or edited the .m files after generating them through mwrap. This has been fixed now. Regarding the other todo's
I've renamed some test files to be more consistent with matlab test notation, and updated contents.m accordingly |
@mrachh I think I messed that up (docs in the .m instead of the .mw). I can try to fix. I think Alex made the changes in the .mw... |
Yes I did change the .mw, as the SSOT. But at the very end I forgot to run I might suggest that emfmm3d return U.Etarg, U.curlEtarg, U.divEtarg In general, there is a duplication problem in docs that's worth fixing. Ie, |
This documents the MATLAB/octave interfaces better for all 4 kernels, and the Stokes fortran source code docs. It does not change the website (docs/) or any lines of code apart from one example.
Mixture of:
help(pwd)
frommatlab
directory), labeling legacy codes as such.Note: since I had to run "make mex" there are some gateway .c diffs. Let me know if problem.
To do: (not in this PR?)
Discussion: aim to reduce duplication of docs, otherwise future changes will be hard to maintain. Clearly matlab interfaces should have own docs, as we have. But fortran source duplicates the RTD website. One option is have sources point to website for main interfaces, but internal subroutines all stay documented in the source.