Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 reduce size of testing files #78

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

DSilva27
Copy link
Collaborator

@DSilva27 DSilva27 commented Aug 9, 2024

No description provided.

@DSilva27 DSilva27 requested a review from geoffwoollard August 9, 2024 18:33
@DSilva27 DSilva27 self-assigned this Aug 12, 2024
Copy link
Collaborator

@geoffwoollard geoffwoollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the file sizes and they are all very small.

Since all the tests pass I think this can be merged in now.

One suggestion is to add some documentation in somewhere as to how you made the test data. A list of commands, or some .sh script perhaps?

@DSilva27 DSilva27 merged commit 3a588c6 into dev Aug 12, 2024
5 checks passed
@DSilva27
Copy link
Collaborator Author

This is just the osf data after fourier downsampling. I have a notebook where I did this, but not sure what would be the best way to add it here.

@DSilva27 DSilva27 deleted the 75-reduce-size-of-testing-files branch August 15, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants