Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added flavor keys #74

Merged
merged 7 commits into from
Aug 9, 2024
Merged

added flavor keys #74

merged 7 commits into from
Aug 9, 2024

Conversation

Miro-Astore
Copy link
Collaborator

addressed #73 by making icecream flavor assignment a separate field in the json file.

@Miro-Astore Miro-Astore requested a review from DSilva27 August 8, 2024 22:04
Copy link
Collaborator

@DSilva27 DSilva27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and passes all tests. I will give it a look tomorrow, and make sure it gives the same ids. I'll approve as soon as possible.

@DSilva27
Copy link
Collaborator

DSilva27 commented Aug 9, 2024

I cleaned up a little bit, and removed an unused variable. Now I just have to remove the seed assignment flavor key from the preprocessing config file

@DSilva27 DSilva27 merged commit fc99c96 into dev Aug 9, 2024
5 checks passed
@DSilva27 DSilva27 linked an issue Aug 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flavor keys to preprocessing json files.
2 participants