Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Github Actions #33

Merged
merged 4 commits into from
Jul 12, 2024
Merged

New Github Actions #33

merged 4 commits into from
Jul 12, 2024

Conversation

DavidHerreros
Copy link
Collaborator

@DavidHerreros DavidHerreros commented Jul 3, 2024

  • Prevent branches from merging PR to main. Only PR from dev can be merged
  • Publish new release to Pypi and tag new version in the repository (currently will not work)

@DavidHerreros
Copy link
Collaborator Author

DavidHerreros commented Jul 3, 2024

After merging this PR, it will not be possible to merge branches into main unless the PR is coming from dev. Therefore, this PR will stablish the following workflow for future releases:

new_branch -> dev -> main -> New release (Pypi and tag)

As it can be seen from the checks, Check merging branch will fail as the PR is not coming from devel. Once this is merge, there will be a ruleset for main that will ensure that all checks (including as well Check merging branch) have been passed succesfully before allowing to merge.

@DavidHerreros
Copy link
Collaborator Author

DavidHerreros commented Jul 3, 2024

Please @geoffwoollard, could you check if these changes make sense before marking this PR as "Ready for review".

Also, I would not merge this until everything is ready to be released into Pypi. To do that, some extra configuration in the repo will be needed (we can discuss about this configuration changes on a separate issue).

@geoffwoollard
Copy link
Collaborator

The fact I'm seeing this, means it's working.

We'll also have to check that dev can indeed merge into main... (once this is merged).

Screen Shot 2024-07-09 at 1 56 27 PM

@geoffwoollard geoffwoollard marked this pull request as ready for review July 9, 2024 17:57
@geoffwoollard geoffwoollard merged commit 047b1ca into main Jul 12, 2024
4 of 5 checks passed
@geoffwoollard geoffwoollard added the enhancement New feature or request label Jul 12, 2024
@geoffwoollard
Copy link
Collaborator

Closes #30

DSilva27 pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants