incorporate pytest in github workflows

[geoffwoollard]

#2

[geoffwoollard]

@DavidHerreros please review.

Do you know of a way to cut down on the 3 min for installs? It would be nice to get it down to under 30s, so as to have rapid testing of PRs. Although a developer can also run pytest locally...

[DavidHerreros]

@DavidHerreros please review.

Do you know of a way to cut down on the 3 min for installs? It would be nice to get it down to under 30s, so as to have rapid testing of PRs. Although a developer can also run pytest locally...

Hi @geoffwoollard

What about this?

The idea would be to cache the virtual environment GitHub actions create during the installation of the pip packages. The first time the tests are run due to a PR, the installation will take the 3 minutes as usual, but in the next executions it wil first check if the environment has been cached an load it if available, reducing almost to zero the installation time.

Also, if any dependency changes in a PR, the whole installation will be redone and cached to consider the new requrements.

I am happy to implement this in the GitHub actions and test it if you think it could be an instersting way to solve the problem 👍

[DavidHerreros]

I have added omegaconf package to the dev requirements in the project toml file to allow running the test locally as the dependency was missing from the installation.

Apart from that, everything runs great! Before merging we might want to consider the virtul environment cache I commented before to speed up the PR testing.

[geoffwoollard]

@DavidHerreros please review.
Do you know of a way to cut down on the 3 min for installs? It would be nice to get it down to under 30s, so as to have rapid testing of PRs. Although a developer can also run pytest locally...

Hi @geoffwoollard

What about this?

The idea would be to cache the virtual environment GitHub actions create during the installation of the pip packages. The first time the tests are run due to a PR, the installation will take the 3 minutes as usual, but in the next executions it wil first check if the environment has been cached an load it if available, reducing almost to zero the installation time.

Also, if any dependency changes in a PR, the whole installation will be redone and cached to consider the new requrements.

I am happy to implement this in the GitHub actions and test it if you think it could be an instersting way to solve the problem 👍

Please do implement this.

[geoffwoollard]

I've merged, but please do submit a PR on this.