Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto #685

pm4rcin · 2024-07-05T21:15:24Z

It requires testing from people on different DEs but also checking if IMEs work.

flathubbot · 2024-07-05T21:15:40Z

flathubbot · 2024-07-05T21:48:47Z

Build 132855 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/115854/org.signal.Signal.flatpakref

pm4rcin · 2024-07-15T10:28:30Z

@codewiz since you mentioned that it worked for you in chrome #577 (comment) it would be nice if you could check setting flag --enable-wayland-ime in desktop file. @czhang03 would you try that too?

czhang03 · 2024-07-15T12:54:17Z

Hi, IME still doesn't work on my machine. AFAIK this is not new, IME is completely broken with electron gnome and wayland, because of the mismatched text-input implementation.

System Info:

OS Name: Fedora Linux 40.20240714.0 (Silverblue)
OS Type: 64-bit
GNOME Version: 46
Windowing System: Wayland
Kernel Version: Linux 6.9.8-200.fc40.x86_64

pm4rcin · 2024-07-15T13:00:50Z

Hi, IME still doesn't work on my machine. AFAIK this is not new, IME is completely broken with electron gnome and wayland, because of the mismatched text-input implementation.

Did you try both IBUS and fcitx? Sorry I'm not an expert on IM but I think IBUS supports wayland in newest versions with GTK or smth.

czhang03 · 2024-07-15T14:30:31Z

Hi, sorry I was not being clear earlier, I am using the default input method that comes with Gnome, which I believe runs on ibus.

I believe this is also the most common way people install IMs on gnome.

czhang03 · 2024-07-31T19:40:17Z

It seems like both the chrome side and gnome side are moving forward on the issue of IM:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3751
https://chromium-review.googlesource.com/c/chromium/src/+/5690113

Gnome already have a working implementation of text-input-v1 (an old protocol that chrome supports) with experimental packages for both fedora and AUR. And chrome is starting the implementation of text-input-v3 (the newer protocol that is supported in Gnome and other DEs).

At this point, given the discussion, it seems that the text-input-v1 is unlikely to get merged in Gnome, since it has been deprecated for a while. And people might want to wait until chrome has text-input-v3. But obviously it depends on what the developers think. I am just here to spread the good news :)

flathubbot · 2024-08-26T19:22:02Z

Started test build 142722

flathubbot · 2024-08-26T19:24:19Z

Build 142722 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/125772/org.signal.Signal.flatpakref

flathubbot · 2024-10-14T19:59:16Z

Started test build 154230

flathubbot · 2024-10-14T20:05:42Z

Build 154230 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/137320/org.signal.Signal.flatpakref

czhang03 · 2024-10-14T20:40:18Z

For a bit of update on the electron+wayland IEM issue, since people mentioned it.

Starting with chrome 129 (which is the current version), wayland IEM can be enabled by enabling the text-input-v3 flag in chrome:flag or with the following command line flag --enable-wayland-ime --wayland-text-input-version=3.

The current version of electron (32, based on chromium 128) still doesn't support this feature. However, electron 33 which is based on chromium 130, will probably support this feature; and electron 33 is set to become stable tomorrow (Oct 15th). https://www.electronjs.org/docs/latest/tutorial/electron-timelines

flathubbot · 2024-11-01T12:48:28Z

Started test build 158291

flathubbot · 2024-11-01T12:54:33Z

Build 158291 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/141376/org.signal.Signal.flatpakref

czhang03 · 2024-11-10T17:52:27Z

I have tested that the latest version of signal (version 7.32.0) can use IME in wayland mode.

Here are the command line arguments:

flatpak run org.signal.Signal --ozone-platform-hint=auto --enable-wayland-ime --wayland-text-input-version=3

Signed-off-by: Marcin Pachur <[email protected]>

czhang03 · 2024-11-10T18:48:31Z

I think it is important to at least provide an environmental variable for people to enable input method --enable-wayland-ime --wayland-text-input-version=3, it can also automatically be on when ELECTRON_OZONE_PLATFORM_HINT is set to auto or wayland

pm4rcin · 2024-11-10T18:59:16Z

bot, build

flathubbot · 2024-11-10T18:59:18Z

Queued test build for org.signal.Signal.

Signed-off-by: Marcin Pachur <[email protected]>

flathubbot · 2024-11-11T00:14:30Z

Started test build 161034

flathubbot · 2024-11-11T00:24:59Z

Build 161034 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/144106/org.signal.Signal.flatpakref

czhang03 · 2024-11-11T07:56:46Z

Somehow input method is not working in the test version... Maybe we want to put in some debug message in the script. I will do more testing later.

czhang03 · 2024-11-11T08:06:32Z

There are two problems I have with this current commit

the IME should also be enabled when ozone platform is set to wayland instead of auto
I am not sure the electron environmental variable is case-sensitive, i.e. does electron treat AUTO also as auto. If so, our detection should act accordingly.

czhang03 · 2024-11-11T12:10:48Z

This is very unexpected, even if I added the command line parameter, the current test build still doesn't work with IME:

$ flatpak run org.signal.Signal --enable-wayland-ime --wayland-text-input-version=3
Debug: Using password store: basic
Debug: Will run signal with the following arguments: --password-store=basic
Debug: Additionally, user gave: --enable-wayland-ime --wayland-text-input-version=3
ERROR: ld.so: object '/var/run/host/usr/lib64/glibc-hwcaps/x86-64-v4/libhardened_malloc.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Set Windows Application User Model ID (AUMID) { AUMID: 'org.whispersystems.signal-desktop' }
NODE_ENV production
NODE_CONFIG_DIR /app/Signal/resources/app.asar/config
NODE_CONFIG {}
ALLOW_CONFIG_MUTATIONS undefined
HOSTNAME cheng-fedora-framework-laptop
NODE_APP_INSTANCE undefined
SUPPRESS_NO_CONFIG_WARNING undefined
SIGNAL_ENABLE_HTTP undefined
userData: /var/home/<user>/.var/app/org.signal.Signal/config/Signal
config/get: Successfully read user config file
config/get: Successfully read ephemeral config file
making app single instance

$ flatpak info org.signal.Signal 

Signal Desktop - Private messenger

          ID: org.signal.Signal
         Ref: app/org.signal.Signal/x86_64/test
        Arch: x86_64
      Branch: test
     Version: 7.32.0
     License: AGPL-3.0-only
      Origin: signal-origin
  Collection: org.flathub.Test.Build144106
Installation: user
   Installed: 472.4 MB
     Runtime: org.freedesktop.Platform/x86_64/24.08
         Sdk: org.freedesktop.Sdk/x86_64/24.08

      Commit: f7b73fb1cfeb0587a5fc0bbc1b76005e41bfe880dae7f2b06b272b3470eaf291
     Subject: feat(manifest): enable input method if ELECTRON_OZONE_PLATFORM_HINT=auto (2fdda198)
        Date: 2024-11-11 00:23:30 +0000

Comparatively, I got the following log when running the stable version:

$ flatpak info org.signal.Signal 

Signal Desktop - Private messenger

          ID: org.signal.Signal
         Ref: app/org.signal.Signal/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 7.32.0
     License: AGPL-3.0-only
      Origin: flathub
  Collection: org.flathub.Stable
Installation: user
   Installed: 472.4 MB
     Runtime: org.freedesktop.Platform/x86_64/24.08
         Sdk: org.freedesktop.Sdk/x86_64/24.08

      Commit: 738b400e7710fdd066d0875fdda3cf546bf3183c0a1a8f79aacae580c4f3f7e6
      Parent: 243fadb832b10837ddb723b8c017db77f853f2cd7f5d3d0f8538412770aba89f
     Subject: signal-desktop: Update signal-desktop.deb to 7.32.0 (#781) (8bff0dc3)
        Date: 2024-11-07 06:50:50 +0000


$ flatpak run org.signal.Signal --enable-wayland-ime --wayland-text-input-version=3
Debug: Using password store: basic
Debug: Will run signal with the following arguments: --password-store=basic
Debug: Additionally, user gave: --enable-wayland-ime --wayland-text-input-version=3
ERROR: ld.so: object '/var/run/host/usr/lib64/glibc-hwcaps/x86-64-v4/libhardened_malloc.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Set Windows Application User Model ID (AUMID) { AUMID: 'org.whispersystems.signal-desktop' }
NODE_ENV production
NODE_CONFIG_DIR /app/Signal/resources/app.asar/config
NODE_CONFIG {}
ALLOW_CONFIG_MUTATIONS undefined
HOSTNAME <reducted>
NODE_APP_INSTANCE undefined
SUPPRESS_NO_CONFIG_WARNING undefined
SIGNAL_ENABLE_HTTP undefined
userData: /var/home/<reducted>/.var/app/org.signal.Signal/config/Signal
config/get: Successfully read user config file
config/get: Successfully read ephemeral config file
making app single instance
LaunchProcess: failed to execvp:
xdg-settings
LaunchProcess: failed to execvp:
xdg-settings
{"level":30,"time":"2024-11-11T12:07:56.772Z","msg":"got fast localeOverride setting null"}
{"level":30,"time":"2024-11-11T12:07:56.773Z","msg":"app.ready: hour cycle preference: UnknownPreference"}
{"level":30,"time":"2024-11-11T12:07:56.773Z","msg":"app.ready: preferred system locales: en-US, en"}
{"level":30,"time":"2024-11-11T12:07:56.774Z","msg":"locale: Supported locales: af-ZA, ar, az-AZ, bg-BG, bn-BD, bs-BA, ca, cs, da, de, el, en, es, et-EE, eu, fa-IR, fi, fr, ga-IE, gl-ES, gu-IN, he, hi-IN, hr-HR, hu, id, it, ja, ka-GE, kk-KZ, km-KH, kn-IN, ko, ky-KG, lt-LT, lv-LV, mk-MK, ml-IN, mr-IN, ms, my, nb, nl, pa-IN, pl, pt-BR, pt-PT, ro-RO, ru, sk-SK, sl-SI, sq-AL, sr, sv, sw, ta-IN, te-IN, th, tl-PH, tr, ug, uk-UA, ur, vi, yue, zh-CN, zh-HK, zh-Hant"}
{"level":30,"time":"2024-11-11T12:07:56.774Z","msg":"locale: Preferred locales: <reducted>"}
{"level":30,"time":"2024-11-11T12:07:56.774Z","msg":"locale: Locale Override: null"}
{"level":30,"time":"2024-11-11T12:07:56.777Z","msg":"locale: Matched locale: en"}
{"level":40,"time":"2024-11-11T12:07:56.808Z","msg":"intl.onWarn [@formatjs/intl] \"defaultRichTextElements\" was specified but \"message\" was not pre-compiled. \nPlease consider using \"@formatjs/cli\" to pre-compile your messages for performance.\nFor more details see https://formatjs.io/docs/getting-started/message-distribution"}
{"level":30,"time":"2024-11-11T12:07:56.808Z","msg":"locale: Text info direction for en: ltr"}
{"level":30,"time":"2024-11-11T12:07:56.809Z","msg":"getSQLKey: using legacy key"}
{"level":30,"time":"2024-11-11T12:07:56.809Z","msg":"getSystemTraySetting got value MinimizeToAndStartInSystemTray"}
{"level":30,"time":"2024-11-11T12:07:56.809Z","msg":"getSystemTraySetting returning MinimizeToAndStartInSystemTray"}
{"level":30,"time":"2024-11-11T12:07:56.810Z","msg":"app ready"}
{"level":30,"time":"2024-11-11T12:07:56.810Z","msg":"starting version 7.32.0"}
...

bermeitinger-b mentioned this pull request Oct 14, 2024

fallback-x11 socket instead of x11 socket? #640

Closed

feat(manifest): switch socket from x11 to fallback-x11

216b6da

Signed-off-by: Marcin Pachur <[email protected]>

pm4rcin force-pushed the patch-1 branch from eaf3d84 to 216b6da Compare November 10, 2024 18:46

pm4rcin closed this Nov 10, 2024

pm4rcin deleted the patch-1 branch November 10, 2024 18:47

pm4rcin restored the patch-1 branch November 10, 2024 18:47

pm4rcin reopened this Nov 10, 2024

feat(manifest): enable input method if ELECTRON_OZONE_PLATFORM_HINT=auto

2fdda19

Signed-off-by: Marcin Pachur <[email protected]>

pm4rcin changed the title ~~Use fallback X11 socket~~ Use fallback X11 socket and enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto Nov 10, 2024

pm4rcin changed the title ~~Use fallback X11 socket and enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto~~ Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto Nov 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto #685

Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto #685

pm4rcin commented Jul 5, 2024

flathubbot commented Jul 5, 2024

flathubbot commented Jul 5, 2024

pm4rcin commented Jul 15, 2024

czhang03 commented Jul 15, 2024 •

edited

Loading

pm4rcin commented Jul 15, 2024

czhang03 commented Jul 15, 2024

czhang03 commented Jul 31, 2024

flathubbot commented Aug 26, 2024

flathubbot commented Aug 26, 2024

flathubbot commented Oct 14, 2024

flathubbot commented Oct 14, 2024

czhang03 commented Oct 14, 2024

flathubbot commented Nov 1, 2024

flathubbot commented Nov 1, 2024

czhang03 commented Nov 10, 2024 •

edited

Loading

czhang03 commented Nov 10, 2024

pm4rcin commented Nov 10, 2024

flathubbot commented Nov 10, 2024

flathubbot commented Nov 11, 2024

flathubbot commented Nov 11, 2024

czhang03 commented Nov 11, 2024

czhang03 commented Nov 11, 2024

czhang03 commented Nov 11, 2024 •

edited

Loading

Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto #685

Are you sure you want to change the base?

Use fallback X11 socket. Enable input method when ELECTRON_OZONE_PLATFORM_HINT=auto #685

Conversation

pm4rcin commented Jul 5, 2024

flathubbot commented Jul 5, 2024

flathubbot commented Jul 5, 2024

pm4rcin commented Jul 15, 2024

czhang03 commented Jul 15, 2024 • edited Loading

pm4rcin commented Jul 15, 2024

czhang03 commented Jul 15, 2024

czhang03 commented Jul 31, 2024

flathubbot commented Aug 26, 2024

flathubbot commented Aug 26, 2024

flathubbot commented Oct 14, 2024

flathubbot commented Oct 14, 2024

czhang03 commented Oct 14, 2024

flathubbot commented Nov 1, 2024

flathubbot commented Nov 1, 2024

czhang03 commented Nov 10, 2024 • edited Loading

czhang03 commented Nov 10, 2024

pm4rcin commented Nov 10, 2024

flathubbot commented Nov 10, 2024

flathubbot commented Nov 11, 2024

flathubbot commented Nov 11, 2024

czhang03 commented Nov 11, 2024

czhang03 commented Nov 11, 2024

czhang03 commented Nov 11, 2024 • edited Loading

czhang03 commented Jul 15, 2024 •

edited

Loading

czhang03 commented Nov 10, 2024 •

edited

Loading

czhang03 commented Nov 11, 2024 •

edited

Loading