Add me.jtheoof.swappy

[zefr0x]

Please confirm your submission meets all the criteria

• I have read the App Requirements and App Maintenance pages.
• My pull request follows the instructions at App Submission.
• I have built and tested the submission locally.
• I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
• All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
• I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
• I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
• Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

[zefr0x]

bot, build me.jtheoof.swappy

[flathubbot]

Queued test build for me.jtheoof.swappy.

[flathubbot]

Started test build 82734

[flathubbot]

Build 82734 failed

[zefr0x]

bot, build me.jtheoof.swappy

[flathubbot]

Queued test build for me.jtheoof.swappy.

[flathubbot]

Started test build 82735

[flathubbot]

Build 82735 failed

[hfiguiere]

this file is never installed.

also it should be upstreamed.

[zefr0x]

I made a PR: jtheoof/swappy#158

I hope the developer will response soon.

[hfiguiere]

jtheoof.me doesn't seem to have a website. it's hard to verify it's actually valid.

[zefr0x]

It's used in upstream: https://github.com/jtheoof/swappy/blob/596b9a8b17234303a9d4d2ea1d3107cb5442253e/src/application.c#L948

Should I use io.github.jtheoof.swappy instead?

[hfiguiere]

then you should ask them at the same time as you contact them.

[zefr0x]

bot, build me.jtheoof.swappy

[flathubbot]

Queued test build for me.jtheoof.swappy.

[flathubbot]

Started test build 82754

[flathubbot]

Build 82754 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65388/me.jtheoof.swappy.flatpakref

[bbhtt]

bot, build me.jtheoof.swappy

[flathubbot]

Queued test build for me.jtheoof.swappy.

[flathubbot]

Started test build 82797

[flathubbot]

Build 82797 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65431/me.jtheoof.swappy.flatpakref

[bbhtt]

Please test the above build

[bbhtt]

Looks like copying the image does not work. It depends on wl-clipboard https://github.com/jtheoof/swappy/blob/596b9a8b17234303a9d4d2ea1d3107cb5442253e/src/clipboard.c#L35 can you add these in the manifest and check if it works?

[zefr0x]

It works without it actually, but when you close the app it will be lost from the clipboard. (The normal behavior for any application, without a clipboard manager in your desktop)

With wl-clipboard it will be available even after closing the application.

This should only be possible in wlroots based Wayland compositors and KDE:
https://wayland.app/protocols/wlr-data-control-unstable-v1
Basically it's a hole in Wayland's security.

I think with a clipboard manager it will not make any difference but I need to test it in a real desktop environment since I don't use any clipboard manager.

[hfiguiere]

https://wayland.app/protocols/wlr-data-control-unstable-v1

This is not availble with gnome-shell.

[bbhtt]

If it expects to use wl-copy/paste to persistently copy-paste, I think it'd be better to give it that.

It works without it actually, but when you close the app

Yes.

Another thing, the desktop file has NoDisplay=true, but this is a type=desktop-application in metainfo, not a console one. This would be confusing to people installing the application for the first time.

[zefr0x]

Another thing, the desktop file has NoDisplay=true, but this is a type=desktop-application in metainfo, not a console one. This would be confusing to people installing the application for the first time.

Should I change it to console-application in metainfo file?

It's a weird application, we can't open it without passing a file to it (so we should not show it in applications menu), but it has a GUI. It should be visible from context menu in file managers when opening an image.

[zefr0x]

It seems it relay on FontAwesome v5 in buttons to display UTF-8 icons, so I did add it.

https://github.com/jtheoof/swappy/blob/596b9a8b17234303a9d4d2ea1d3107cb5442253e/res/style/swappy.css#L2

[barthalion]

bot, build me.jtheoof.swappy

[flathubbot]

Queued test build for me.jtheoof.swappy.

[flathubbot]

Started test build 83049

[flathubbot]

Build 83049 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65685/me.jtheoof.swappy.flatpakref

[bbhtt]

It's a weird application, we can't open it without passing a file to it (so we should not show it in applications menu), but it has a GUI. It should be visible from context menu in file managers when opening an image.

I was hoping there would be some way to spawn an empty GUI..

Also, the program doesn't have a close button.

[barthalion]

Yeah, it doesn't look like a good fit for Flathub right now.