Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tasks and Calculator permissions. #534

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

edfloreshz
Copy link
Contributor

This PR adds write permission to dev.edfloreshz.Tasks and dev.edfloreshz.Calculator to be able to write app configuration files.

@bbhtt
Copy link
Contributor

bbhtt commented Nov 8, 2024

why do app's config files go in xdg-config/cosmic? Shouldn't they be in app's own folder?

@bbhtt bbhtt added the exceptions Request to add exceptions label Nov 8, 2024
@edfloreshz
Copy link
Contributor Author

The app config files are managed by cosmic-config, it saves them to xdg-config/cosmic/com.example.App/v1/setting-file.

@bbhtt bbhtt merged commit 1883a44 into flathub-infra:master Nov 8, 2024
5 checks passed
@edfloreshz
Copy link
Contributor Author

We initially granted read-only permissions to the xdg-config/cosmic directory to enable reading theme changes. However, we subsequently discovered that once any level of host access is provided, crates like xdg or dirs prioritize the host.

This makes it challenging to write app configuration to the sandbox while simultaneously reading theme changes from the host, unless there's an alternative approach we've overlooked

@hfiguiere
Copy link
Contributor

the alternative would be for Cosmic to implemnent this through DBus. I know it's work but it comes with the territory of reinventing the wheel.

@edfloreshz
Copy link
Contributor Author

I believe that will happen at some point, but in the meantime we still have to rely on this.

@bbhtt bbhtt mentioned this pull request Nov 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exceptions Request to add exceptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants