finish-args: Add check to catch incorrect secret service talk-name

flatpak_builder_lint/checks/finish_args.py

@@ -186,6 +186,13 @@ def _validate(self, appid: str | None, finish_args: dict[str, set[str]]) -> None
             ):
                 self.errors.add("finish-args-flatpak-talk-name")
 
+            if talk_name == "org.freedesktop.Secrets":
+                self.errors.add("finish-args-incorrect-secret-service-talk-name")
+                self.info.add(
+                    "finish-args-incorrect-secret-service-talk-name: The name is in lower case"
+                    + " org.freedesktop.secrets"
+                )
+
         for sys_own_name in finish_args["system-own-name"]:
             if sys_own_name == "org.freedesktop.*":
                 self.errors.add("finish-args-wildcard-freedesktop-system-own-name")

tests/manifests/finish_args-incorrect_secrets-talk-name.json

@@ -0,0 +1,6 @@
+{
+    "app-id": "org.flathub.finish_args",
+    "finish-args": [
+        "--talk-name=org.freedesktop.Secrets"
+    ]
+}

tests/test_manifest.py

@@ -176,6 +176,12 @@ def test_manifest_finish_args_issue_wayland_x11() -> None:
     assert "finish-args-contains-both-x11-and-wayland" in found_errors
 
 
+def test_manifest_finish_args_incorrect_secret_talk_name() -> None:
+    ret = run_checks("tests/manifests/finish_args-incorrect_secrets-talk-name.json")
+    found_errors = set(ret["errors"])
+    assert "finish-args-incorrect-secret-service-talk-name" in found_errors
+
+
 def test_manifest_finish_args_issue_33() -> None:
     ret = run_checks("tests/manifests/own_name_substring.json")
     found_errors = set(ret["errors"])