Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check basic validity of desktop and appstream before publishing #9

Closed
ramcq opened this issue Jul 28, 2017 · 2 comments
Closed

check basic validity of desktop and appstream before publishing #9

ramcq opened this issue Jul 28, 2017 · 2 comments

Comments

@ramcq
Copy link
Contributor

ramcq commented Jul 28, 2017

Discord doesn't appear in GNOME Software, so must be missing some key fields. We should validate the basic stuff is there (meeting our submission guidelines) before publishing.
@TingPing
Copy link
Contributor

TingPing commented Aug 4, 2017

Discord doesn't appear in GNOME Software, so must be missing some key fields.

This is because any package using extra-data will not have an icon downloaded and gnome-software does not show these.

This has been discussed with @hughsie and the solution is we need to find/host their icons somewhere and appstream-util validate-relax needs to be relaxed further to consider remote icons valid.

hughsie added a commit to hughsie/appstream-glib that referenced this issue Aug 4, 2017
@hughsie
Allow remote icon types for desktop AppData files
74ebf51 
If the icon is not redistributable we have to download the icon at runtime.

Fixes: flathub-infra/buildbot-config#9
@TingPing TingPing mentioned this issue Apr 19, 2018
Closed
@bbhtt
Copy link

bbhtt commented Oct 17, 2024

Linter does both and a lot more https://github.com/flathub-infra/flatpak-builder-lint

@bbhtt bbhtt closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramcq @TingPing @bbhtt