Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flathub not updating? #8

Closed
fabiocolacio opened this issue Apr 19, 2018 · 8 comments
Closed

Flathub not updating? #8

fabiocolacio opened this issue Apr 19, 2018 · 8 comments

Comments

@fabiocolacio
Copy link
Collaborator

Flathub still lists Marker as version 2018.01.23 which is the first version published on Flathub. Despite several changes to this repository which were all successfully built by the bot, Flathub does not seem to be updating the app. Is there something else that I need to do that I am just missing here?

@TingPing
Copy link
Member

Probably because your releases are in the wrong order? https://github.com/fabiocolacio/Marker/blob/master/data/com.github.fabiocolacio.marker.appdata.xml#L60-L71

@TingPing
Copy link
Member

Also Release notes: <a>https://github.com/fabiocolacio/Marker/releases/tag/2018.03.09</a> is invalid. It needs to be in a <p> block.

@fabiocolacio
Copy link
Collaborator Author

I see, thank you @TingPing for the speedy reply.

Is there some kind of tool that I can use to check if the appdata.xml file is valid or not? I would rather have a definitive way to check if it is invalid than simply making a change and praying it works.

In general, the lack of feedback from Flathub regarding whether an update is valid is very frustrating. The build bot is useful, but as this issue demonstrates, a successful build does not necessarily mean that Flathub will take the update; If something goes wrong, developers are left wondering why it didn't work because there is no feedback. I know that Flathub is still in early days, but are there any plans to improve this in the future?

@TingPing
Copy link
Member

appstream-util validate (also validate-relax)

@TingPing
Copy link
Member

As for Flathub being more useful about errors it is planned: flathub-infra/buildbot-config#9

@fabiocolacio
Copy link
Collaborator Author

I look forward to seeing what Flathub has to offer in the future. I think it is a great service. Thanks for the help!

@TingPing
Copy link
Member

BTW since you use Meson here is a test snippet for validating appstream files: https://github.com/TingPing/transmission-remote-gnome/blob/master/data/meson.build#L87-L92

@fabiocolacio
Copy link
Collaborator Author

Thanks for the tip. That looks useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants