This repository has been archived by the owner on May 30, 2023. It is now read-only.
sys-apps/ignition: upgrade to 2.14.0 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
force-pushed
the
tormath1/ignition
branch
2 times, most recently
from
d25d713 to
931012e
Compare
krnowak
reviewed
May 31, 2022
sys-apps/ignition/files/0005-config-v3_4-convert-ignition-2.x-to-3.4-exp.patch
Outdated
Show resolved
Hide resolved
sys-apps/ignition/files/0005-config-v3_4-convert-ignition-2.x-to-3.4-exp.patch
Show resolved
Hide resolved
sys-apps/ignition/files/0006-internal-prv-cmdline-backport-flatcar-patch.patch
Outdated
Show resolved
Hide resolved
sys-apps/ignition/files/0010-VMware-Fix-guestinfo.-.config.data-and-.config.url-v.patch
Outdated
Show resolved
Hide resolved
|
Looks good! I think it makes sense to test all OEM platforms for this change before merging. |
tormath1
force-pushed
the
tormath1/ignition
branch
from
6e6ff33 to
3960941
Compare
krnowak
approved these changes
Jun 1, 2022
|
If you want, you can squash the commits because the changes belong together |
this pulls release 2.14.0 Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/ignition
branch
from
3960941 to
83118a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition has released a new version, CHANGELOG is available here: https://github.com/coreos/ignition/releases/tag/v2.14.0
Here some high level changes for the patches:
ign-converteris directly pulled to its latest version: 0.2.0 - so we can drop this two patches: https://github.com/flatcar-linux/coreos-overlay/blob/b9235d9188b489b6484792c53851febdd3cc71c5/sys-apps/ignition/ignition-9999.ebuild#L60-L61io.Writeras argument instead of*os.File: https://github.com/flatcar-linux/coreos-overlay/blob/b9235d9188b489b6484792c53851febdd3cc71c5/sys-apps/ignition/files/0013-Revert-drop-OEM-URI-support.patch#L179Revert-drop-OEM-URI-support.patchand0010-VMware-Fix-guestinfo.-.config.data-and-.config.url-v.patchwere the most painful to port.Related-To: flatcar/Flatcar#656
changelog/directory (user-facing change, bug fix, security fix, update)